Merged
Conversation
lenemter
requested changes
Aug 18, 2025
Member
lenemter
left a comment
lenemter
left a comment
There was a problem hiding this comment.
I don't see the accelerator in the menu..?
master:
This branch:
Collaborator
Author
|
Hmm, looks like I got confused with which version was running again 😞 Just tried again and the menu accel is gone. However, I think it worth fixing that separately from actually getting the accel to work (see @danirabbit comments on previous attempt (#1626)) |
lenemter
approved these changes
Oct 18, 2025
Member
lenemter
left a comment
lenemter
left a comment
There was a problem hiding this comment.
All shortcuts appear to work as intended so LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that Granite.AccelLabel does not show accelerator strings for accelerators containing a default target so a separate action with no target is created for the cases where a file chooser will be shown and this is used instead.